Skip to content

[ci] Remove check for dar upload during party migration #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicu-da merged 1 commit into from
Jun 6, 2025
Merged

[ci] Remove check for dar upload during party migration #1016

nicu-da merged 1 commit into from
Jun 6, 2025

Conversation

@nicu-da
Copy link
Contributor

@nicu-da nicu-da commented Jun 6, 2025 •
edited
Loading

The dars are already uploaded in a previous step

Fixes #1015

  • Run a manual test

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@nicu-da nicu-da requested a review from moritzkiefer-da June 6, 2025 07:28
moritzkiefer-da
moritzkiefer-da approved these changes Jun 6, 2025
View reviewed changes
Copy link
Contributor

@moritzkiefer-da moritzkiefer-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stampystamp

@nicu-da nicu-da force-pushed the nicuda/fix/dar_upload_party_migrate branch from 48661a4 to cf94978 Compare June 6, 2025 12:59
@nicu-da
[ci] .
b7e14a3 
Signed-off-by: Nicu Reut <[email protected]>

[ci] Remove check for dar upload during party migration

The dars are already uploaded in a previous step
@nicu-da nicu-da force-pushed the nicuda/fix/dar_upload_party_migrate branch from cf94978 to b7e14a3 Compare June 6, 2025 13:00
@nicu-da
Copy link
Contributor Author

nicu-da commented Jun 6, 2025

Ran manual integration tests started with the old packages as we do in the bootstrap integration test and it worked

2025-06-06T13:03:33.702Z [⋮] INFO - o.l.s.v.ValidatorApp:ValidatorReonboardingWithPartiesToMigrateIntegrationTest/config=7444add2/validator=aliceValidatorLocal (c1551f3a51b9f4d15cb04d66122cd521-app_init--8bb244aed927394c) - ValidatorLicense found => already onboarded. 
2025-06-06T13:03:33.702Z [⋮] INFO - o.l.s.v.ValidatorApp:ValidatorReonboardingWithPartiesToMigrateIntegrationTest/config=7444add2/validator=aliceValidatorLocal (c1551f3a51b9f4d15cb04d66122cd521-app_init--8bb244aed927394c) - aliceValidatorLocal app initialization: Initialization complete, running on version 0.4.2-nicu-dirty

@nicu-da nicu-da enabled auto-merge (squash) June 6, 2025 13:06
@nicu-da nicu-da merged commit ae8d6ee into main Jun 6, 2025
60 checks passed
@nicu-da nicu-da deleted the nicuda/fix/dar_upload_party_migrate branch June 6, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moritzkiefer-da moritzkiefer-da moritzkiefer-da approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Recover validator with party migration is broken when latest dar is not uploaded

3 participants

@nicu-da @moritzkiefer-da